Merged
Conversation
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 2 to 3. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v2...v3) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 3 to 4. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v3...v4) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erequisites.ps1 (adamrehn#345)
There are `pdb` files, not prefaced with `UnrealEngine`, which are expected to be present when creating a shipping build.
Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5 to 6. - [Release notes](https://github.com/release-drafter/release-drafter/releases) - [Commits](release-drafter/release-drafter@v5...v6) --- updated-dependencies: - dependency-name: release-drafter/release-drafter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Just-released docker-py 7.1.0 contains the fix: https://github.com/docker/docker-py/releases/tag/7.1.0 This reverts commit 9e2dfc3.
See adamrehn#281 and adamrehn/conan-ue4cli#20 This also requires adamrehn/conan-ue4cli#15 to make `ue4 conan generate` work on UE5.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Unreal Engine 5.6.0 on Ubuntu 24.04, representing a significant version update with extensive refactoring and modernization of the ue4-docker codebase.
- Adds support for UE 5.6.0 and Ubuntu 24.04, updating supported release versions and removing deprecated older versions
- Implements comprehensive test suite infrastructure for automated UE release testing with credential management
- Modernizes build system with debug support, IPv6 compatibility checks, and improved error handling
Reviewed Changes
Copilot reviewed 51 out of 53 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| test-suite/test-ue-releases.py | New comprehensive test framework for automated UE release builds with credential management |
| src/ue4docker/infrastructure/BuildConfiguration.py | Major refactor of Visual Studio configuration and updated UE version support |
| src/ue4docker/build.py | Enhanced build process with debug support and IPv6 warnings |
| pyproject.toml | Version bump to 0.0.116 and minimum Python requirement updated to 3.8 |
Comments suppressed due to low confidence (1)
src/ue4docker/infrastructure/BuildConfiguration.py:668
- The format string uses
self.visualStudiodirectly, but earlier in the same functionself.visualStudio.nameis used. This should be consistent and likely should beself.visualStudio.name.
self.visualStudio
| try: | ||
| import colorama | ||
| from termcolor import colored | ||
| except: |
There was a problem hiding this comment.
Using bare except: clause is discouraged. Consider catching specific exceptions like ImportError or ModuleNotFoundError.
Suggested change
| except: | |
| except (ImportError, ModuleNotFoundError): |
src/ue4docker/dockerfiles/ue4-build-prerequisites/windows/install-prerequisites.ps1
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missim ue is broken in jazzy [sc-14392]