chore: add Metrics in FlightMetadata#134
Merged
waynexia merged 4 commits intoGreptimeTeam:mainfrom Jan 16, 2024
Merged
Conversation
Merged
3 tasks
shuiyisong
force-pushed
the
chore/metrics_metadata
branch
from
89ac896 to
b764e20
Compare
MichaelScofield
approved these changes
Jan 16, 2024
waynexia
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly adds a
Metricsfield inFlightMetadata, allowing us to carry metrics from datanode to frontend. We usebyteshere for compatibility reason in case we want to change encoding later(currently in json/string).Checklist
Refer to a related PR or issue link (optional)