chore: change create database api#143
Merged
tisonkun merged 1 commit intoGreptimeTeam:mainfrom Apr 9, 2024
Merged
Conversation
tisonkun
approved these changes
Apr 9, 2024
Contributor
|
Thank you! |
Contributor
|
@shuiyisong Although, is this patch a breaking change? If so, call it "chore" looks mismatched. |
Contributor
I think it's only used internally. So from a user's perspective I assume it is a not breaking change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
As described in GreptimeTeam/greptimedb#3662, change
database_nametoschema_namefor consistency.Checklist
Refer to a related PR or issue link (optional)