Skip to content

feat: add source_tables and source_table_ids#151

Merged
waynexia merged 5 commits intoGreptimeTeam:mainfrom
WenyXu:feat/flow-task
Apr 25, 2024
Merged

feat: add source_tables and source_table_ids#151
waynexia merged 5 commits intoGreptimeTeam:mainfrom
WenyXu:feat/flow-task

Conversation

@WenyXu
Copy link
Copy Markdown
Member

@WenyXu WenyXu commented Apr 25, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add source_tables to CreateFlowTaskExpr
  2. Add source_table_ids to FlowCreateRequest
  3. Rename CreateTaskExpr to CreateFlowTaskExpr
  4. Rename RemoveTaskExpr to RemoveFlowTaskExpr
  5. Introduce ScheamScopedTableName(struct { schema_name, table_name })
  6. Rename FlowCreateRequest to CreateRequest.
  7. Rename FlowRemoveRequest to RemoveRequest.
  8. rename output_ to sink_.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 93ebc1b into GreptimeTeam:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants