Skip to content

feat: adds node info to heartbeat request#160

Merged
fengjiachun merged 1 commit intoGreptimeTeam:mainfrom
killme2008:feature/improve-heartbeat
Apr 30, 2024
Merged

feat: adds node info to heartbeat request#160
fengjiachun merged 1 commit intoGreptimeTeam:mainfrom
killme2008:feature/improve-heartbeat

Conversation

@killme2008
Copy link
Copy Markdown
Member

@killme2008 killme2008 commented Apr 29, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Adds NodeInfo to HeartbeatRequest that carries build info and node startup timestamp etc.

Used in GreptimeTeam/greptimedb#3832

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@killme2008 killme2008 force-pushed the feature/improve-heartbeat branch from 8399174 to 7f1be11 Compare April 30, 2024 01:06
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit f699e24 into GreptimeTeam:main Apr 30, 2024
@killme2008 killme2008 deleted the feature/improve-heartbeat branch April 30, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants