Skip to content

refactor: remove task suffix #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waynexia merged 2 commits into from
Apr 29, 2024
Merged

refactor: remove task suffix #162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37eff6
refactor: remove task suffix
WenyXu Apr 29, 2024
4e65a82
chore: rename task_options to flow_options
WenyXu Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
687 changes: 343 additions & 344 deletions c++/greptime/v1/ddl.pb.cc
View file
Open in desktop

Large diffs are not rendered by default.

816 changes: 408 additions & 408 deletions c++/greptime/v1/ddl.pb.h
View file
Open in desktop

Large diffs are not rendered by default.

309 changes: 154 additions & 155 deletions c++/greptime/v1/flow/server.pb.cc
View file
Open in desktop

Large diffs are not rendered by default.

404 changes: 202 additions & 202 deletions c++/greptime/v1/flow/server.pb.h
View file
Open in desktop

Large diffs are not rendered by default.

190 changes: 95 additions & 95 deletions c++/greptime/v1/meta/ddl.pb.cc
View file
Open in desktop

Large diffs are not rendered by default.

224 changes: 112 additions & 112 deletions c++/greptime/v1/meta/ddl.pb.h
View file
Open in desktop

Large diffs are not rendered by default.

572 changes: 284 additions & 288 deletions go/greptime/v1/ddl.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

200 changes: 99 additions & 101 deletions go/greptime/v1/meta/ddl.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

476 changes: 238 additions & 238 deletions java/src/main/java/greptime/v1/meta/Ddl.java
View file
Open in desktop

Large diffs are not rendered by default.

1,205 changes: 602 additions & 603 deletions java/src/main/java/io/greptime/v1/Ddl.java
View file
Open in desktop

Large diffs are not rendered by default.

763 changes: 381 additions & 382 deletions java/src/main/java/io/greptime/v1/flow/Server.java
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions proto/greptime/v1/ddl.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,29 +33,29 @@ message DdlRequest {
AlterExpr alter = 3;
DropTableExpr drop_table = 4;
TruncateTableExpr truncate_table = 7;
CreateFlowTaskExpr create_flow_task = 8;
DropFlowTaskExpr drop_flow_task = 9;
CreateFlowExpr create_flow = 8;
DropFlowExpr drop_flow = 9;
}
}

// Create a flow task to run the SQL when new data arrives.
message CreateFlowTaskExpr {
// Create a flow to run the SQL when new data arrives.
message CreateFlowExpr {
string catalog_name = 1;
string task_name = 2;
string flow_name = 2;
repeated TableName source_table_names = 3;
TableName sink_table_name = 4;
bool or_replace = 5;
bool create_if_not_exists = 6;
string expire_when = 7;
string comment = 8;
string sql = 9;
map<string, string> task_options = 10;
map<string, string> options = 10;
}

// Remove a flow task.
message DropFlowTaskExpr {
// Drop a flow.
message DropFlowExpr {
string catalog_name = 1;
string task_name = 2;
string flow_name = 2;
}

message CreateTableExpr {
Expand Down
8 changes: 4 additions & 4 deletions proto/greptime/v1/flow/server.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ message InsertRequest {
message FlowRequest {
oneof body {
CreateRequest create = 1;
RemoveRequest remove = 2;
DropRequest drop = 2;
}
}

Expand All @@ -55,12 +55,12 @@ message FlowResponse {
repeated TaskId affected_tasks = 4;
}

// Create a flow task
// Create a flow
//
// Very similar to `ddl.CreateTaskExpr`,
// replace `source_table_names` with `source_table_ids`
message CreateRequest {
TaskId task_id = 1;
TaskId flow_id = 1;
repeated TableId source_table_ids = 2;
TableName sink_table_name = 3;
bool create_if_not_exists = 4;
Expand All @@ -70,6 +70,6 @@ message CreateRequest {
map<string, string> task_options = 8;
}

message RemoveRequest { TaskId task_id = 1; }
message DropRequest { TaskId flow_id = 1; }

message TaskId { uint32 id = 1; }
4 changes: 2 additions & 2 deletions proto/greptime/v1/meta/ddl.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ message DropDatabaseTask {
}

message CreateFlowTask {
CreateFlowTaskExpr create_flow_task = 1;
CreateFlowExpr create_flow = 1;
}

message DropFlowTask {
DropFlowTaskExpr drop_flow_task = 1;
DropFlowExpr drop_flow = 1;
}

message DdlTaskRequest {
Expand Down