Skip to content

feat: add flow_id and drop_if_exists to DropFlowExpr#164

Merged
WenyXu merged 3 commits intoGreptimeTeam:mainfrom
WenyXu:drop-flow
May 10, 2024
Merged

feat: add flow_id and drop_if_exists to DropFlowExpr#164
WenyXu merged 3 commits intoGreptimeTeam:mainfrom
WenyXu:drop-flow

Conversation

@WenyXu
Copy link
Copy Markdown
Member

@WenyXu WenyXu commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add flow_id and drop_if_exists to DropFlowExpr

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Comment thread proto/greptime/v1/flow/server.proto Outdated
Comment thread proto/greptime/v1/flow/server.proto Outdated
@WenyXu WenyXu force-pushed the drop-flow branch 2 times, most recently from 7eb57a0 to a26bcfb Compare May 7, 2024 12:35
repeated TaskId affected_tasks = 4;
// affected flow ids
repeated FlowId affected_flows = 3;
map<string, bytes> extension = 4;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
map<string, bytes> extension = 4;
map<string, bytes> extensions = 4;

@WenyXu WenyXu merged commit 219b240 into GreptimeTeam:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants