feat: add json type proto#188
Merged
WenyXu merged 3 commits intoGreptimeTeam:mainfrom Sep 9, 2024
Merged
Conversation
3 tasks
WenyXu
reviewed
Sep 2, 2024
WenyXu
approved these changes
Sep 5, 2024
evenyag
approved these changes
Sep 9, 2024
Contributor
evenyag
left a comment
evenyag
left a comment
There was a problem hiding this comment.
We may merge this after the DB code is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
GreptimeTeam/greptimedb#4619
What's changed and what's your intention?
Corresponding changes.
May not be needed as GreptimeTeam/greptimedb@092ee0cIt's needed now for distinguish binary and json columns from proto.
Checklist