Skip to content

feat: add expr for altering table attributes#192

Merged
v0y4g3r merged 4 commits intoGreptimeTeam:mainfrom
v0y4g3r:feat/add-modify-table-attr-expr
Oct 30, 2024
Merged

feat: add expr for altering table attributes#192
v0y4g3r merged 4 commits intoGreptimeTeam:mainfrom
v0y4g3r:feat/add-modify-table-attr-expr

Conversation

@v0y4g3r
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r commented Oct 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add expr for altering table attributes like TTL

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@v0y4g3r v0y4g3r requested review from WenyXu and fengjiachun October 17, 2024 04:02
@v0y4g3r v0y4g3r force-pushed the feat/add-modify-table-attr-expr branch from 38948d4 to f81189a Compare October 17, 2024 05:15
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge (squash) October 29, 2024 19:57
@v0y4g3r v0y4g3r force-pushed the feat/add-modify-table-attr-expr branch from 30927df to f7fccaf Compare October 29, 2024 19:59
 Added ChangeTableAttributes to AlterRequest in server.proto

 - Introduced ChangeTableAttributes message handling in AlterRequest.
 - Updated server.pb.cc and server.pb.h to include logic for new ChangeTableAttributes.
 - Altered Java Server class to support ChangeTableAttributes.
 - Incremented descriptor sizes and adjusted field offsets in server.pb.cc.
@v0y4g3r v0y4g3r force-pushed the feat/add-modify-table-attr-expr branch from f7fccaf to 53ab9a9 Compare October 29, 2024 20:13
@v0y4g3r v0y4g3r merged commit 255f87a into GreptimeTeam:main Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants