refactor: remove cluster id#220
Merged
MichaelScofield merged 1 commit intomainfrom Mar 4, 2025
Merged
Conversation
### Remove `cluster_id` Field from Protocol Buffers - **Removed `cluster_id` Field**: The `cluster_id` field has been removed from the `RequestHeader` and `ResponseHeader` messages across multiple langua bindings and source files. This includes updates to: - C++: `common.pb.cc`, `common.pb.h` - Go: `common.pb.go` - Java: `Common.java` - Proto: `common.proto` - Rust: `meta.rs` These changes streamline the protocol by eliminating the `cluster_id` field, simplifying the message structures and related logic.
v0y4g3r
requested review from
WenyXu and
fengjiachun
and removed request for
fengjiachun
5 tasks
MichaelScofield
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Remove
cluster_idField from Protocol Bufferscluster_idField: Thecluster_idfield has been removed from theRequestHeaderandResponseHeadermessages across multiple langua bindings and source files. This includes updates to:common.pb.cc,common.pb.hcommon.pb.goCommon.javacommon.protometa.rsChecklist