feat: add insert into logical plan in request#231
Merged
Conversation
5 tasks
waynexia
approved these changes
Apr 18, 2025
discord9
force-pushed
the
feat/insert_into_logical_plan
branch
from
f44681b to
9a2cbf8
Compare
WenyXu
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
add insert into logical plan in request as substrait doesn't support
WriteReltoInsertIntoin datafusion, this is a workaround for internal use only, hence shouldn't be documented to userPlease explain IN DETAIL what the changes are in this PR and why they are needed:
substrait doesn't support decode
WriteReltoInsertIntoin datafusion, so this workaround is useChecklist