Skip to content

feat: introduce node workloads#235

Merged
MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom
WenyXu:feat/role-metadata
May 9, 2025
Merged

feat: introduce node workloads#235
MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom
WenyXu:feat/role-metadata

Conversation

@WenyXu
Copy link
Copy Markdown
Member

@WenyXu WenyXu commented May 6, 2025 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • Add new workload-based role definitions in heartbeat.proto:
    • Add node_workloads oneof field to HeartbeatRequest to support different node types
    • Add workload type definitions for different node types:
      • DatanodeWorkloadType: HYBRID, INGEST, QUERY
      • FrontendWorkloadType: FRONTEND_DEFAULT
      • FlownodeWorkloadType: FLOWNODE_DEFAULT
    • Add corresponding workload message types:
      • DatanodeWorkloads
      • FrontendWorkloads
      • FlownodeWorkloads

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@WenyXu WenyXu requested a review from fengjiachun May 6, 2025 09:26
@WenyXu WenyXu force-pushed the feat/role-metadata branch 4 times, most recently from 43fc11f to 0f2b1f6 Compare May 6, 2025 11:18
@WenyXu WenyXu mentioned this pull request May 6, 2025
Merged
5 tasks
@WenyXu WenyXu marked this pull request as draft May 7, 2025 02:50
@WenyXu WenyXu force-pushed the feat/role-metadata branch from 0f2b1f6 to adbb73c Compare May 7, 2025 02:50
@WenyXu WenyXu changed the title feat: introduce DatanodeRoleMetadata feat: add datanode mode support May 7, 2025
@WenyXu WenyXu force-pushed the feat/role-metadata branch 3 times, most recently from 6d8b8bb to 5b72327 Compare May 7, 2025 03:15
fengjiachun
fengjiachun approved these changes May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the feat/role-metadata branch 11 times, most recently from 9832776 to 6fc6201 Compare May 8, 2025 09:28
@WenyXu WenyXu changed the title feat: add datanode mode support feat: introduce node workloads May 8, 2025
@WenyXu WenyXu marked this pull request as ready for review May 8, 2025 09:50
@WenyXu WenyXu force-pushed the feat/role-metadata branch from 6fc6201 to 4ed272c Compare May 9, 2025 04:16
@WenyXu WenyXu force-pushed the feat/role-metadata branch from 8f00336 to fd3bdcb Compare May 9, 2025 06:36
@MichaelScofield MichaelScofield merged commit 7668a88 into GreptimeTeam:main May 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WenyXu @MichaelScofield @fengjiachun