Conversation
5 tasks
### Refactor `ArrowIpc` and Remove `RegionSelection` - **Refactor `ArrowIpc` Structure**: - Moved `region_id` to be the first field in `ArrowIpc`. - Removed `region_selection` field from `ArrowIpc`. - Updated field numbers for `schema` and `payload` in `ArrowIpc`. - Affected files: `server.pb.cc`, `server.pb.h`, `Server.java`, `server.proto`. - **Remove `RegionSelection` Message**: - Deleted the `RegionSelection` message and its related code. - Affected files: `server.pb.cc`, `server.pb.h`, `Server.java`, `server.proto`. These changes streamline the `ArrowIpc` message structure and remove unused `RegionSelection` components.
v0y4g3r
force-pushed
the
feat/remove-region-selection
branch
from
822b993 to
6ad4825
Compare
evenyag
approved these changes
May 8, 2025
WenyXu
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Remove region selection to simplify region bulk inserts handling in datanode.
Checklist