Conversation
Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new soft_drop boolean flag to greptime.v1.region.DropRequest so callers can request a “mark dropped without physical deletion” behavior via the Region server API.
Changes:
- Extend
DropRequestinproto/greptime/v1/region/server.protowithbool soft_drop = 5. - Regenerate protobuf outputs for Rust, Go, Java, and C++ to include the new field and accessors.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/generated/greptime.v1.region.rs | Rust prost-generated DropRequest gains soft_drop field. |
| proto/greptime/v1/region/server.proto | Source proto adds soft_drop field and documentation. |
| java/src/main/java/io/greptime/v1/region/Server.java | Java protobuf output updated with softDrop field/accessors and serialization support. |
| go/greptime/v1/region/server.pb.go | Go protobuf output updated with SoftDrop field and getter. |
| c++/greptime/v1/region/server.pb.h | C++ protobuf header updated with soft_drop APIs and storage. |
| c++/greptime/v1/region/server.pb.cc | C++ protobuf implementation updated for parse/serialize/merge/size with soft_drop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
evenyag
approved these changes
Apr 28, 2026
v0y4g3r
force-pushed
the
feat/add-soft-drop
branch
from
85d2dbb to
091f253
Compare
Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
Add `check-protoc` target to ensure local `protoc` matches version `3.21.12`. This prevents generating inconsistent grpc service descriptors due to compiler version mismatches. - Updated `Makefile` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
10 tasks
WenyXu
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As title
Checklist