feat: handle multiple InsertRequests in GRPC method#47
Merged
MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom Jun 2, 2023
MichaelScofield:feat/buffer-inserts
Merged
feat: handle multiple InsertRequests in GRPC method#47MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom MichaelScofield:feat/buffer-inserts
InsertRequests in GRPC method#47MichaelScofield merged 3 commits intoGreptimeTeam:mainfrom
MichaelScofield:feat/buffer-inserts
Conversation
fengjiachun
reviewed
Jun 1, 2023
fengjiachun
approved these changes
Jun 1, 2023
auto-merge was automatically disabled
June 1, 2023 03:49
Pull request was converted to draft
fengys1996
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
An
InsertRequestcorresponding to a single table, which impedes our write throughtput. This PR makes our GRPC method capable of handling multipleInsertRequests at once, could greatly improve the speed of ingesting data.Checklist
Refer to a related PR or issue link (optional)