Skip to content

feat: add ddl task service#53

Merged
WenyXu merged 3 commits intoGreptimeTeam:mainfrom
WenyXu:feat/add-ddl-task
Jun 28, 2023
Merged

feat: add ddl task service#53
WenyXu merged 3 commits intoGreptimeTeam:mainfrom
WenyXu:feat/add-ddl-task

Conversation

@WenyXu
Copy link
Copy Markdown
Member

@WenyXu WenyXu commented Jun 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Removes Create in the Router
  2. Adds DDL task service

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the feat/add-ddl-task branch from a4e33b1 to ade9d3a Compare June 28, 2023 03:11
Comment thread proto/greptime/v1/meta/ddl.proto Outdated
Comment thread proto/greptime/v1/meta/ddl.proto Outdated

service DdlTask {
// Submits a DDL task to meta.
rpc SubmitDdlTask(AddDdlTaskRequest) returns (AddDdlTaskResponse);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to ask for the execution status?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns directly in the response.

@WenyXu WenyXu force-pushed the feat/add-ddl-task branch from 44c3bc0 to eb81ec3 Compare June 28, 2023 04:55
@WenyXu
Copy link
Copy Markdown
Member Author

WenyXu commented Jun 28, 2023

PTAL @MichaelScofield @fengjiachun

@WenyXu WenyXu force-pushed the feat/add-ddl-task branch from f052ce9 to 4cc607c Compare June 28, 2023 06:54
@WenyXu WenyXu force-pushed the feat/add-ddl-task branch from 4cc607c to b7eeec6 Compare June 28, 2023 07:20
@WenyXu WenyXu merged commit f82201d into GreptimeTeam:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants