Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
shuiyisong
approved these changes
Jul 11, 2023
Member
Author
I'm currently on a temporary env 😖 All I can do is begging to the make suparman @evenyag to make it for me |
evenyag
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add
TraceIDandSpanIDin the request header as distributed context. Related to GreptimeTeam/greptimedb#1312The opentelemetry protocol definition is at https://opentelemetry.io/docs/specs/otel/trace/api/#spancontext. From its spec, trace id's max type is uint128. But it's not supported in protobuf (doc). Thus I fallback to uint64 instead.
Checklist
Refer to a related PR or issue link (optional)