Skip to content

feat: support c++ targets#60

Merged
v0y4g3r merged 3 commits intoGreptimeTeam:mainfrom
v0y4g3r:feat/support-cpp-target
Jul 11, 2023
Merged

feat: support c++ targets#60
v0y4g3r merged 3 commits intoGreptimeTeam:mainfrom
v0y4g3r:feat/support-cpp-target

Conversation

@v0y4g3r
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r commented Jul 11, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Generates C++ files.

Also include all files under proto for C++ and Java targets.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r force-pushed the feat/support-cpp-target branch from 8911f3d to 4b20570 Compare July 11, 2023 09:31
@v0y4g3r v0y4g3r force-pushed the feat/support-cpp-target branch from 4b20570 to 4e458b8 Compare July 11, 2023 09:32
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DLJB

Comment thread scripts/generate-cpp.sh Outdated
Comment thread scripts/generate-java.sh Outdated
Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 7de3f31 into GreptimeTeam:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants