Skip to content

feat: adds time column type#62

Merged
v0y4g3r merged 1 commit intomainfrom
feature/time-duration-type
Jul 13, 2023
Merged

feat: adds time column type#62
v0y4g3r merged 1 commit intomainfrom
feature/time-duration-type

Conversation

@killme2008
Copy link
Copy Markdown
Member

@killme2008 killme2008 commented Jul 12, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Adds Time type. A piece of patch to fix GreptimeTeam/greptimedb#1885

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 force-pushed the feature/time-duration-type branch from eb3afa3 to a404019 Compare July 12, 2023 07:39
@killme2008 killme2008 changed the title feat: adds time and duration column type feat: adds time column type Jul 12, 2023
@killme2008 killme2008 force-pushed the feature/time-duration-type branch from a404019 to b099573 Compare July 13, 2023 03:16
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit ab5bc48 into main Jul 13, 2023
@v0y4g3r v0y4g3r deleted the feature/time-duration-type branch July 13, 2023 03:44
@killme2008 killme2008 restored the feature/time-duration-type branch July 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported arrow data type, type: Time64(Nanosecond)

3 participants