Skip to content

fix: modify cpp grpc CMakeLists.txt#68

Merged
Nateiru merged 4 commits intoGreptimeTeam:mainfrom
Nateiru:chore/change-cmake
Jul 18, 2023
Merged

fix: modify cpp grpc CMakeLists.txt#68
Nateiru merged 4 commits intoGreptimeTeam:mainfrom
Nateiru:chore/change-cmake

Conversation

@Nateiru
Copy link
Copy Markdown
Contributor

@Nateiru Nateiru commented Jul 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix some mistakes in CMakeLists.txt

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Nateiru added 3 commits July 14, 2023 10:24
Signed-off-by: ZhuZiyi <zyzhu2001@gmail.com>
Signed-off-by: ZhuZiyi <zyzhu2001@gmail.com>
Signed-off-by: ZhuZiyi <zyzhu2001@gmail.com>
@Nateiru Nateiru requested review from WenyXu and v0y4g3r July 18, 2023 05:45
@v0y4g3r
Copy link
Copy Markdown
Contributor

v0y4g3r commented Jul 18, 2023

Please resolve the conflicts.

@Nateiru Nateiru enabled auto-merge (squash) July 18, 2023 06:13
v0y4g3r

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nateiru Nateiru merged commit 16b327e into GreptimeTeam:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants