Skip to content

feat: define region server related messages#79

Merged
waynexia merged 9 commits intomainfrom
region
Aug 15, 2023
Merged

feat: define region server related messages#79
waynexia merged 9 commits intomainfrom
region

Conversation

@waynexia
Copy link
Copy Markdown
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

define a new service for datanode (region server). Compared to the existing GreptimeDatabase, the new RegionServer is considered internal.

The planned usage of this service is to handle all requests to region, except the query request, which will be handled in flight.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Comment thread proto/greptime/v1/region/server.proto Outdated
Comment thread proto/greptime/v1/region/server.proto Outdated
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from evenyag August 15, 2023 08:35
Comment thread proto/greptime/v1/region/server.proto Outdated
Comment thread proto/greptime/v1/region/server.proto Outdated
Comment thread proto/greptime/v1/common.proto Outdated
Comment thread proto/greptime/v1/region/server.proto Outdated
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from evenyag August 15, 2023 09:15
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia merged commit dbb8e52 into main Aug 15, 2023
@waynexia waynexia deleted the region branch August 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants