Skip to content

feat: from valuedata for value#82

Merged
MichaelScofield merged 1 commit intomainfrom
feat/from-valuedata
Aug 21, 2023
Merged

feat: from valuedata for value#82
MichaelScofield merged 1 commit intomainfrom
feat/from-valuedata

Conversation

@fengjiachun
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

impl From<ValueData> for Value

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield merged commit 3489b47 into main Aug 21, 2023
@MichaelScofield MichaelScofield deleted the feat/from-valuedata branch August 21, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants