Skip to content

chore: rename RegionServer to Region#85

Merged
evenyag merged 2 commits intomainfrom
rename-region-server
Aug 25, 2023
Merged

chore: rename RegionServer to Region#85
evenyag merged 2 commits intomainfrom
rename-region-server

Conversation

@waynexia
Copy link
Copy Markdown
Member

@waynexia waynexia commented Aug 25, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • rename RegionServer to Region, to avoid generating structs like RegionServerServer and RegionServerService
  • rename request to region_request_body, to make it more distinguishable

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Comment thread proto/greptime/v1/region/server.proto Outdated
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 708866d into main Aug 25, 2023
@evenyag evenyag deleted the rename-region-server branch August 25, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants