refactor: remove **all** unnecessary 'optional' notation#91
Merged
fengjiachun merged 1 commit intoGreptimeTeam:mainfrom Aug 30, 2023
Merged
refactor: remove **all** unnecessary 'optional' notation#91fengjiachun merged 1 commit intoGreptimeTeam:mainfrom
fengjiachun merged 1 commit intoGreptimeTeam:mainfrom
Conversation
zyy17
changed the title
zyy17
changed the title
waynexia
approved these changes
Aug 30, 2023
Member
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
Changes related to trace are fine to me. We can add special logic for the default value 0
fengjiachun
approved these changes
Aug 30, 2023
shuiyisong
added a commit
that referenced
this pull request
Aug 30, 2023
This reverts commit e8e228b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
refactor: remove all unnecessary
optionalnotation.Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)