Skip to content

bump: update version of greptime-proto and delete duration related fields #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanbohan merged 2 commits into from
Apr 30, 2024
Merged

bump: update version of greptime-proto and delete duration related fields #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861b3cb
bump: update version of proto and delete duration releated fields
Apr 30, 2024
bcff12c
delete duration related fields in types.go
Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/GreptimeTeam/greptimedb-ingester-go
go 1.20

require (
github.com/GreptimeTeam/greptime-proto v0.4.3
github.com/GreptimeTeam/greptime-proto v0.7.0
github.com/stoewer/go-strcase v1.3.0
github.com/stretchr/testify v1.8.4
google.golang.org/grpc v1.56.3
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ github.com/GreptimeTeam/greptime-proto v0.4.2 h1:oX6N1v6+bYQDrh/QM+JmMHqEWjlxAVo
github.com/GreptimeTeam/greptime-proto v0.4.2/go.mod h1:jk5XBR9qIbSBiDF2Gix1KALyIMCVktcpx91AayOWxmE=
github.com/GreptimeTeam/greptime-proto v0.4.3 h1:qJC2j03AfP2YbfVrBBlB6t+Sd1RvMG6zKVtGUwtj7N0=
github.com/GreptimeTeam/greptime-proto v0.4.3/go.mod h1:jk5XBR9qIbSBiDF2Gix1KALyIMCVktcpx91AayOWxmE=
github.com/GreptimeTeam/greptime-proto v0.7.0 h1:WHBjAu+NWDFcbZgW9kPtksxEKEAeqYemP1HY63QuO48=
github.com/GreptimeTeam/greptime-proto v0.7.0/go.mod h1:jk5XBR9qIbSBiDF2Gix1KALyIMCVktcpx91AayOWxmE=
github.com/Microsoft/go-winio v0.6.0 h1:slsWYD/zyx7lCXoZVlvQrj0hPTM1HI4+v1sIda2yDvg=
github.com/Microsoft/go-winio v0.6.0/go.mod h1:cTAf44im0RAYeL23bpB+fzCyDH2MJiz2BO69KH/soAE=
github.com/Nvveen/Gotty v0.0.0-20120604004816-cd527374f1e5 h1:TngWCqHvy9oXAN6lEVMRuU21PR1EtLVZJmdB18Gu3Rw=
Expand Down
6 changes: 0 additions & 6 deletions schema/field.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,6 @@ func parseValue(typ gpb.ColumnDataType, val reflect.Value) (*gpb.Value, error) {
gpb.ColumnDataType_INTERVAL_MONTH_DAY_NANO:
return nil, fmt.Errorf("INTERVAL not implemented yet for %#v", val)

case gpb.ColumnDataType_DURATION_SECOND,
gpb.ColumnDataType_DURATION_MILLISECOND,
gpb.ColumnDataType_DURATION_MICROSECOND,
gpb.ColumnDataType_DURATION_NANOSECOND:
return nil, fmt.Errorf("DURATION not supported for %#v", val)

// TODO(yuanbohan): support decimal 128
case gpb.ColumnDataType_DECIMAL128:
return nil, fmt.Errorf("DECIMAL 128 not supported for %#v", val)
Expand Down
6 changes: 0 additions & 6 deletions table/cell/cell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ func (c Cell) Build() (*gpb.Value, error) {
gpb.ColumnDataType_INTERVAL_MONTH_DAY_NANO:
return nil, fmt.Errorf("INTERVAL not implemented yet for %#v", c.Val)

case gpb.ColumnDataType_DURATION_SECOND,
gpb.ColumnDataType_DURATION_MILLISECOND,
gpb.ColumnDataType_DURATION_MICROSECOND,
gpb.ColumnDataType_DURATION_NANOSECOND:
return nil, fmt.Errorf("DURATION not supported for %#v", c.Val)

// TODO(yuanbohan): support decimal 128
case gpb.ColumnDataType_DECIMAL128:
return nil, fmt.Errorf("DECIMAL 128 not supported for %#v", c.Val)
Expand Down
4 changes: 0 additions & 4 deletions table/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ const (
// INTERVAL_YEAR_MONTH ColumnType = 23
// INTERVAL_DAY_TIME ColumnType = 24
// INTERVAL_MONTH_DAY_NANO ColumnType = 25
// DURATION_SECOND ColumnType = 26
// DURATION_MILLISECOND ColumnType = 27
// DURATION_MICROSECOND ColumnType = 28
// DURATION_NANOSECOND ColumnType = 29
// DECIMAL128 ColumnType = 30

// the following types are not from protocol buffer
Expand Down