[refactor](ingester-example): reorganize project structure and improve database connection configuration. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zqr10159
commented
May 24, 2025
zqr10159
commented
- Rename packages to better reflect their purpose (e.g., quickstart, benchmark).
- Move database connection logic to a central DBConnector class.
- Use properties file for database connection details.
- fix deamon to daemon.
…database connection - Rename packages to better reflect their purpose (e.g., quickstart, benchmark) - Move database connection logic to a central DBConnector class - Use properties file for database connection details - Update logging and error handling - Improve code readability and maintainability
|
@fengjiachun Hi, please help review it, thanks! |
|
@zqr10159 Hi, thank you for your contribution. There are two minor issues to address:
|
Ok. I will fix them soon. |
- Update README with correct file paths for examples- Reorganize import statements in Java files for better readability
You can also modify the code format according to the prompts here: https://github.com/GreptimeTeam/greptimedb-ingester-java/actions/runs/15228347898/job/42871103593?pr=86 |
fengjiachun
reviewed
May 26, 2025
ingester-example/src/main/java/io/greptime/bench/benchmark/BatchingWriteBenchmark.java
Show resolved
Hide resolved
|
Thank you. I have fixed them. Please help me see if there are any other problems. |
fengjiachun
reviewed
May 26, 2025
ingester-example/src/main/java/io/greptime/bench/benchmark/BulkWriteBenchmark.java
Show resolved
Hide resolved
fengjiachun
reviewed
May 26, 2025
ingester-example/src/main/java/io/greptime/bench/benchmark/StreamingWriteBenchmark.java
Show resolved
Hide resolved
fengjiachun
approved these changes
May 26, 2025
…asses - Remove db_endpoint and db_name from BulkWriteBenchmark and StreamingWriteBenchmark - Update class comments to reflect the removal of these environment variables
- Remove comments about db_endpoint and db_name as they are not relevant to the batching write benchmark- Keep existing information about batch_size_per_request, zstd_compression, and max_points_per_second
v0.14.6 has been released, which includes this fix. cc @zqr10159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.