Skip to content

refactor(storage): remove unused FlushIo variant#1002

Merged
waynexia merged 1 commit intoGreptimeTeam:developfrom
etolbakov:refactor/remove-unused-variant
Feb 15, 2023
Merged

refactor(storage): remove unused FlushIo variant#1002
waynexia merged 1 commit intoGreptimeTeam:developfrom
etolbakov:refactor/remove-unused-variant

Conversation

@etolbakov
Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Removed unused FlushIo variant .

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#855

@etolbakov
Copy link
Copy Markdown
Collaborator Author

etolbakov commented Feb 14, 2023

@evenyag
As per your suggestion in #855 FlushIo is removed.
Could you please have look in the meantime?

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1002 (0765abd) into develop (374acc8) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1002      +/-   ##
===========================================
- Coverage    86.24%   85.98%   -0.26%     
===========================================
  Files          432      432              
  Lines        62494    62494              
===========================================
- Hits         53897    53736     -161     
- Misses        8597     8758     +161     
Flag Coverage Δ
rust 85.98% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/common/substrait/src/df_expr.rs 30.81% <0.00%> (-16.56%) ⬇️
src/datanode/src/instance.rs 41.56% <0.00%> (-14.91%) ⬇️
tests-integration/src/test_util.rs 79.47% <0.00%> (-9.33%) ⬇️
src/datatypes/src/data_type.rs 98.26% <0.00%> (+0.34%) ⬆️
src/mito/src/table.rs 88.63% <0.00%> (+0.51%) ⬆️
src/common/substrait/src/df_logical.rs 78.77% <0.00%> (+0.87%) ⬆️
src/common/substrait/src/types.rs 51.92% <0.00%> (+0.96%) ⬆️
src/meta-srv/src/service/heartbeat.rs 87.23% <0.00%> (+1.06%) ⬆️
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evenyag evenyag changed the title refactor(storeage): remove unused FlushIo variant refactor(storage): remove unused FlushIo variant Feb 15, 2023
Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waynexia waynexia merged commit 4d82767 into GreptimeTeam:develop Feb 15, 2023
@etolbakov etolbakov deleted the refactor/remove-unused-variant branch February 15, 2023 20:14
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
refactor(storeage): remove unused FlushIo variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants