Skip to content

feat: add catalog name to s3 path#1011

Merged
sunng87 merged 1 commit intoGreptimeTeam:developfrom
sunng87:feature/s3-catalog-path
Feb 15, 2023
Merged

feat: add catalog name to s3 path#1011
sunng87 merged 1 commit intoGreptimeTeam:developfrom
sunng87:feature/s3-catalog-path

Conversation

@sunng87
Copy link
Copy Markdown
Member

@sunng87 sunng87 commented Feb 15, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fixes #1004

This patch adds catalog name to our s3 path.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@waynexia waynexia added the breaking-change This pull request contains breaking changes. label Feb 15, 2023
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 enabled auto-merge (squash) February 15, 2023 08:21
@sunng87
Copy link
Copy Markdown
Member Author

sunng87 commented Feb 15, 2023

cc @zyy17 @shuiyisong

@sunng87 sunng87 merged commit 40eec85 into GreptimeTeam:develop Feb 15, 2023
@sunng87 sunng87 deleted the feature/s3-catalog-path branch February 15, 2023 10:58
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This pull request contains breaking changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add catalog name to s3 file path

3 participants