refactor: changes CreateTableRequest::schema to RawSchema#1018
Merged
v0y4g3r merged 2 commits intoGreptimeTeam:developfrom Feb 16, 2023
Merged
refactor: changes CreateTableRequest::schema to RawSchema#1018v0y4g3r merged 2 commits intoGreptimeTeam:developfrom
v0y4g3r merged 2 commits intoGreptimeTeam:developfrom
Conversation
d65457f to
e5ac42f
Compare
37 tasks
1b04c41 to
8d1e3b8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1018 +/- ##
===========================================
- Coverage 86.23% 85.95% -0.28%
===========================================
Files 436 436
Lines 63279 63269 -10
===========================================
- Hits 54568 54386 -182
- Misses 8711 8883 +172
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelScofield
approved these changes
Feb 16, 2023
v0y4g3r
approved these changes
Feb 16, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…am#1018) * refactor: changes CreateTableRequest::schema to RawSchema * refactor(grpc-expr): create_table_schema returns RawSchema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR use
RawSchemaas the type ofCreateTableRequest::schemato make it easier to serialize and deserialize contents ofCreateTableRequest.This is useful for implementing a procedure that creates a table because it needs to serialize and deserialize the request and pass the request to the table engine. The subprocedure created by the table engine may again need to serialize it.
Checklist
Refer to a related PR or issue link (optional)