refactor: separate compaction stuff from task scheduler#1021
Merged
waynexia merged 12 commits intoGreptimeTeam:developfrom Feb 16, 2023
Merged
refactor: separate compaction stuff from task scheduler#1021waynexia merged 12 commits intoGreptimeTeam:developfrom
waynexia merged 12 commits intoGreptimeTeam:developfrom
Conversation
v0y4g3r
requested review from
evenyag,
killme2008 and
waynexia
and removed request for
killme2008
Codecov Report
@@ Coverage Diff @@
## develop #1021 +/- ##
===========================================
- Coverage 86.09% 85.88% -0.21%
===========================================
Files 436 437 +1
Lines 63288 63432 +144
===========================================
- Hits 54486 54479 -7
- Misses 8802 8953 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…#1021) * refactor: make schedule request return value generic * feat: add handler trait * wip * feat: use task handler * fix: unit test * refactor: separate scheduler mod * chore: rename * chore: Request use associate type * refactor: use associate type * refactor: use associate type to reduce generic parameters * chore: further remove generic types * chore: further remove a generic parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR move the compaction logic out of
CompactionSchedulerso that the scheduler can be used by file purger and flush.Checklist
Refer to a related PR or issue link (optional)