feat: impl insert data from query#1025
Merged
MichaelScofield merged 13 commits intoGreptimeTeam:developfrom Feb 17, 2023
Merged
feat: impl insert data from query#1025MichaelScofield merged 13 commits intoGreptimeTeam:developfrom
MichaelScofield merged 13 commits intoGreptimeTeam:developfrom
Conversation
6f270be to
e2c9682
Compare
8322d48 to
b2151b7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1025 +/- ##
===========================================
- Coverage 86.02% 85.94% -0.09%
===========================================
Files 437 439 +2
Lines 63432 63871 +439
===========================================
+ Hits 54568 54892 +324
- Misses 8864 8979 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sunng87
reviewed
Feb 17, 2023
Member
sunng87
left a comment
There was a problem hiding this comment.
Add @shuiyisong , please verify if this can bypass our cross-schema access check, for both insert and select
Member
Author
sunng87
approved these changes
Feb 17, 2023
MichaelScofield
approved these changes
Feb 17, 2023
52 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: refactor insertion in datanode * feat: supports inserting data by select query * feat: impl cast operation for vector * feat: streaming insert from select query results * chore: minor changes * fix: remove unwrap * test: insert_to_requsts * test: test_execute_insert_by_select * fix: cast operation for vectors * fix: test * fix: typo * chore: by CR comments * fix: test_statement_to_request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Supports inserting data which is queried by a
selectstatement.For example:
After this feature is implemented, we can begin to implement inserting data from files such as CSV, parquet etc.I will create another PR to cover this feature in sqlness test.
Checklist
Refer to a related PR or issue link (optional)
Close #760