Skip to content

feat: admin http api#1026

Merged
fengys1996 merged 11 commits intoGreptimeTeam:developfrom
jun0315:admin
Feb 22, 2023
Merged

feat: admin http api#1026
fengys1996 merged 11 commits intoGreptimeTeam:developfrom
jun0315:admin

Conversation

@jun0315
Copy link
Copy Markdown
Contributor

@jun0315 jun0315 commented Feb 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

support admin meta http api.

feature

  1. Query the catalog list.
  2. Query the schema list by catalog name.
  3. Query the table list by catalog name and schema name.
  4. Query table info by full table name.
  5. Query the information of the meta leader node.
  6. Query heartbeat by ip.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@jun0315 jun0315 marked this pull request as ready for review February 17, 2023 02:58
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1026 (9aae0e4) into develop (a19dee1) will decrease coverage by 0.46%.
The diff coverage is 43.66%.

@@             Coverage Diff             @@
##           develop    #1026      +/-   ##
===========================================
- Coverage    85.98%   85.53%   -0.46%     
===========================================
  Files          436      448      +12     
  Lines        62869    65075    +2206     
===========================================
+ Hits         54060    55660    +1600     
- Misses        8809     9415     +606     
Flag Coverage Δ
rust 85.53% <43.66%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/helper.rs 85.50% <ø> (ø)
src/meta-srv/src/service/admin.rs 60.00% <0.00%> (-13.55%) ⬇️
src/meta-srv/src/service/admin/leader.rs 0.00% <0.00%> (ø)
src/meta-srv/src/service/admin/meta.rs 37.39% <37.39%> (ø)
src/meta-srv/src/service/admin/heartbeat.rs 68.67% <86.36%> (+68.67%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/storage/src/compaction/scheduler.rs 8.82% <0.00%> (-80.18%) ⬇️
src/storage/src/compaction/picker.rs 23.07% <0.00%> (-19.24%) ⬇️
src/datatypes/src/vectors/operations.rs 81.35% <0.00%> (-18.65%) ⬇️
src/datanode/src/instance.rs 43.77% <0.00%> (-14.19%) ⬇️
... and 114 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jun0315 jun0315 marked this pull request as draft February 17, 2023 03:42
@jun0315 jun0315 marked this pull request as ready for review February 17, 2023 07:26
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
@fengys1996
Copy link
Copy Markdown
Contributor

Suggest add some unit tests.

Comment thread src/meta-srv/src/service/admin/heartbeat.rs Outdated
Comment thread src/meta-srv/src/service/admin/heartbeat.rs Outdated
Comment thread src/meta-srv/src/service/admin/leader.rs
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/meta.rs Outdated
Comment thread src/meta-srv/src/service/admin/heartbeat.rs
Comment thread src/meta-srv/src/service/admin/meta.rs
Copy link
Copy Markdown
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengys1996 fengys1996 merged commit 390e909 into GreptimeTeam:develop Feb 22, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: catalog list

* feat: catalog list

* feat:api

* feat: leader info

* feat: use constant

* fix: ci

* feat: query heartbeat by ip

* ut: add test

* fix: cr

* fix: cr

* fix: cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants