Skip to content

feat: support influxdb ping and health endpoint#1027

Merged
fengys1996 merged 5 commits intoGreptimeTeam:developfrom
fengys1996:feat/influxdb/ping
Feb 20, 2023
Merged

feat: support influxdb ping and health endpoint#1027
fengys1996 merged 5 commits intoGreptimeTeam:developfrom
fengys1996:feat/influxdb/ping

Conversation

@fengys1996
Copy link
Copy Markdown
Contributor

@fengys1996 fengys1996 commented Feb 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly simply support influxdb ping and health endpoint. (Only status code as response.)

Related Links

  1. https://docs.influxdata.com/influxdb/v1.8/tools/api/#ping-http-endpoint
  2. https://docs.influxdata.com/influxdb/v1.8/tools/api/#health-http-endpoint

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengys1996 fengys1996 marked this pull request as ready for review February 19, 2023 02:40
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2023

Codecov Report

Merging #1027 (920945e) into develop (a8c2b35) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head 920945e differs from pull request most recent head 70bd32c. Consider uploading reports for the commit 70bd32c to get more accurate results

@@             Coverage Diff             @@
##           develop    #1027      +/-   ##
===========================================
- Coverage    86.23%   85.96%   -0.27%     
===========================================
  Files          436      441       +5     
  Lines        63279    64235     +956     
===========================================
+ Hits         54568    55220     +652     
- Misses        8711     9015     +304     
Flag Coverage Δ
rust 85.96% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/servers/src/http.rs 78.11% <100.00%> (+0.10%) ⬆️
src/servers/src/http/authorize.rs 94.79% <100.00%> (+0.92%) ⬆️
src/servers/src/http/influxdb.rs 97.91% <100.00%> (+0.29%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/storage/src/compaction/scheduler.rs 8.82% <0.00%> (-80.18%) ⬇️
src/storage/src/compaction/picker.rs 23.07% <0.00%> (-19.24%) ⬇️
src/datatypes/src/vectors/operations.rs 81.35% <0.00%> (-18.65%) ⬇️
src/common/substrait/src/df_expr.rs 30.81% <0.00%> (-16.56%) ⬇️
src/datanode/src/instance.rs 43.77% <0.00%> (-14.19%) ⬇️
src/storage/src/compaction/task.rs 0.00% <0.00%> (-11.01%) ⬇️
... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengys1996 fengys1996 enabled auto-merge (squash) February 20, 2023 02:07
Comment thread src/servers/src/http.rs
@fengys1996 fengys1996 merged commit 4e88a01 into GreptimeTeam:develop Feb 20, 2023
@fengys1996 fengys1996 deleted the feat/influxdb/ping branch August 15, 2023 13:03
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: support influxdb ping and health endpoint

* add some unit tests

* ping and health api no need auth

* cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants