Skip to content

refactor(storage): Simplify debug output of some structs#1028

Merged
waynexia merged 2 commits intoGreptimeTeam:developfrom
evenyag:refactor/region-debug
Feb 20, 2023
Merged

refactor(storage): Simplify debug output of some structs#1028
waynexia merged 2 commits intoGreptimeTeam:developfrom
evenyag:refactor/region-debug

Conversation

@evenyag
Copy link
Copy Markdown
Contributor

@evenyag evenyag commented Feb 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Simplify debug output of some structs in storage crates

  • RegionImpl
  • BTreeMemtable
  • RegionSchema

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review February 17, 2023 05:50
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1028 (d737f0a) into develop (2f39a77) will increase coverage by 0.04%.
The diff coverage is 58.62%.

@@             Coverage Diff             @@
##           develop    #1028      +/-   ##
===========================================
+ Coverage    86.03%   86.07%   +0.04%     
===========================================
  Files          438      438              
  Lines        63498    63523      +25     
===========================================
+ Hits         54630    54677      +47     
+ Misses        8868     8846      -22     
Flag Coverage Δ
rust 86.07% <58.62%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/region.rs 89.85% <0.00%> (-2.77%) ⬇️
src/storage/src/memtable/btree.rs 97.29% <100.00%> (+0.09%) ⬆️
src/storage/src/schema/region.rs 100.00% <100.00%> (ø)
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 43.77% <0.00%> (-14.34%) ⬇️
tests-integration/src/test_util.rs 79.08% <0.00%> (-9.51%) ⬇️
src/servers/src/opentsdb/codec.rs 99.10% <0.00%> (-0.45%) ⬇️
src/servers/src/postgres/handler.rs 78.59% <0.00%> (-0.19%) ⬇️
src/mito/src/table.rs 88.63% <0.00%> (+0.51%) ⬆️
src/common/substrait/src/df_logical.rs 77.89% <0.00%> (+0.87%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread src/storage/src/region/tests.rs Outdated
Comment thread src/storage/src/region.rs
@evenyag evenyag changed the title refactor: Simplify debug output of RegionImpl refactor(storage): Simplify debug output of some structs Feb 17, 2023
@evenyag evenyag requested review from v0y4g3r and waynexia February 20, 2023 03:02
Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Copy Markdown
Member

@waynexia PTAL

@waynexia waynexia merged commit 6e9964a into GreptimeTeam:develop Feb 20, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…m#1028)

* refactor: Simplify debug output of RegionImpl

* feat: Simplify memtable debug output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants