refactor: remove grpc client constructor with default catalog/schema#1060
Merged
evenyag merged 2 commits intoGreptimeTeam:developfrom Feb 24, 2023
Merged
refactor: remove grpc client constructor with default catalog/schema#1060evenyag merged 2 commits intoGreptimeTeam:developfrom
evenyag merged 2 commits intoGreptimeTeam:developfrom
Conversation
sunng87
force-pushed
the
refactor/grpc-client
branch
from
c0446b5 to
c450194
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1060 +/- ##
===========================================
- Coverage 85.70% 85.57% -0.13%
===========================================
Files 450 450
Lines 65736 65736
===========================================
- Hits 56338 56255 -83
- Misses 9398 9481 +83
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelScofield
approved these changes
Feb 23, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…reptimeTeam#1060) * refactor: remove grpc client with default catalog/schema * refactor: re-export consts in client module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch remove constructor from
Databasethat uses default catalog and schema, to avoid using it in serious cases.Checklist
Refer to a related PR or issue link (optional)