Skip to content

feat: update substrait and prost version#1080

Merged
evenyag merged 1 commit intoGreptimeTeam:developfrom
sunng87:feature/substrait-update
Feb 27, 2023
Merged

feat: update substrait and prost version#1080
evenyag merged 1 commit intoGreptimeTeam:developfrom
sunng87:feature/substrait-update

Conversation

@sunng87
Copy link
Copy Markdown
Member

@sunng87 sunng87 commented Feb 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

While working on an integration with our client and vector, we are blocked by a version conflict on prost. This patch updates substrait and prost to resolve that.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@sunng87 sunng87 force-pushed the feature/substrait-update branch from e7bd306 to 4aeac28 Compare February 24, 2023 09:02
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1080 (4aeac28) into develop (f6e8717) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1080      +/-   ##
===========================================
- Coverage    85.70%   85.60%   -0.10%     
===========================================
  Files          451      451              
  Lines        65998    66000       +2     
===========================================
- Hits         56563    56499      -64     
- Misses        9435     9501      +66     

Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 4b58a8a into GreptimeTeam:develop Feb 27, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants