Conversation
sunng87
requested review from
discord9,
killme2008 and
waynexia
and removed request for
discord9 and
waynexia
killme2008
reviewed
Mar 9, 2023
Contributor
|
LGTM |
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1153 +/- ##
===========================================
+ Coverage 85.13% 85.14% +0.01%
===========================================
Files 482 482
Lines 71065 71065
===========================================
+ Hits 60498 60506 +8
+ Misses 10567 10559 -8 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: make pyo3 optional again * Update src/script/Cargo.toml Co-authored-by: dennis zhuang <killme2008@gmail.com> --------- Co-authored-by: dennis zhuang <killme2008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
As we enabled
pyarrowfeature on arrow by default, pyo3 is a required dependency. This patch updates the feature to be active only whenpyo3_backendturned on.Checklist
Refer to a related PR or issue link (optional)