Skip to content

build: add cross compile docker#1156

Merged
zyy17 merged 10 commits intodevelopfrom
cross_compile_pyo3
Mar 13, 2023
Merged

build: add cross compile docker#1156
zyy17 merged 10 commits intodevelopfrom
cross_compile_pyo3

Conversation

@discord9
Copy link
Copy Markdown
Contributor

@discord9 discord9 commented Mar 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

Added cross-compile docker that produce binary for aarch64-linux-gnu, this should fix build binary

  • Summarize your change:
    This docker first cross compile Python 3.10.10 for both build platform(x86) and target platform(arm64), and then use it's shared library for compiling greptime binary.
    github action release.yml do similiar things.
    this should fix build binary github action

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

@discord9 discord9 marked this pull request as ready for review March 11, 2023 04:32
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2023

Codecov Report

Merging #1156 (fc54f04) into develop (ded31fb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1156      +/-   ##
===========================================
- Coverage    85.14%   85.13%   -0.01%     
===========================================
  Files          482      482              
  Lines        71074    71290     +216     
===========================================
+ Hits         60515    60694     +179     
- Misses       10559    10596      +37     

Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread docker/Arm64CrossCompile.Dockerfile Outdated
Comment thread docker/Arm64CrossCompile.Dockerfile Outdated
Comment thread docker/Arm64CrossCompile.Dockerfile Outdated
Comment thread docker/Arm64CrossCompile.Dockerfile Outdated
Comment thread docker/Arm64CrossCompile.Dockerfile Outdated
Comment thread docker/Arm64CrossCompile.Dockerfile Outdated
@zyy17 zyy17 requested a review from waynexia March 11, 2023 09:58
@zyy17
Copy link
Copy Markdown
Collaborator

zyy17 commented Mar 11, 2023

praise: Finally, we can build the greptime with pyo3 integration for linux-aarch64 successfully 😊 !

@killme2008
Copy link
Copy Markdown
Member

@zyy17 PTAL

Comment thread docker/aarch64/compile-python.sh Outdated
Comment thread docker/aarch64/CrossCompile.Dockerfile
@discord9
Copy link
Copy Markdown
Contributor Author

@zyy17 @waynexia PTAL?

Copy link
Copy Markdown
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Comment thread docker/aarch64/Dockerfile Outdated
Comment thread docker/aarch64/Dockerfile Outdated
@killme2008
Copy link
Copy Markdown
Member

Good job! Let's build a new release for aarch64-linux-gnu.

Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zyy17 zyy17 merged commit 3377930 into develop Mar 13, 2023
@zyy17 zyy17 deleted the cross_compile_pyo3 branch March 13, 2023 08:56
@discord9 discord9 restored the cross_compile_pyo3 branch March 13, 2023 10:00
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* build: add cross compile docker

* build: added compile python to github action

* fix: correct path

* fix: Python Compile

* fix: run mulitple cmds

* fix: both cross compile docker file&github action

* refactor: compile-python.sh

* chore: put wget install together

* fix: CR advices

* chore: add `-F pyo3_backend`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants