Skip to content

feat: execute "delete" in query engine (in the form of "LogicalPlan")#1222

Merged
MichaelScofield merged 1 commit intoGreptimeTeam:developfrom
MichaelScofield:feat/delete-by-plan
Mar 24, 2023
Merged

feat: execute "delete" in query engine (in the form of "LogicalPlan")#1222
MichaelScofield merged 1 commit intoGreptimeTeam:developfrom
MichaelScofield:feat/delete-by-plan

Conversation

@MichaelScofield
Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

part of #1010

execute delete in LogicalPlan, support deletion with general "where" condition

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@MichaelScofield MichaelScofield changed the title fix: execute "delete" in query engine (in the form of "LogicalPlan") feat: execute "delete" in query engine (in the form of "LogicalPlan") Mar 23, 2023
@MichaelScofield MichaelScofield mentioned this pull request Mar 23, 2023
6 tasks
@MichaelScofield MichaelScofield requested a review from sunng87 March 23, 2023 09:53
Comment thread src/query/src/datafusion.rs
Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelScofield MichaelScofield merged commit 92963b9 into GreptimeTeam:develop Mar 24, 2023
@MichaelScofield MichaelScofield deleted the feat/delete-by-plan branch March 24, 2023 04:12
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…GreptimeTeam#1222)

fix: execute "delete" in query engine (in the form of "LogicalPlan")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants