feat: schema level opts#2283
Merged
shuiyisong merged 6 commits intoGreptimeTeam:developfrom Aug 30, 2023
Merged
Conversation
shuiyisong
requested review from
MichaelScofield,
fengys1996,
sunng87 and
waynexia
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2283 +/- ##
===========================================
- Coverage 85.19% 84.78% -0.41%
===========================================
Files 715 715
Lines 117456 117523 +67
===========================================
- Hits 100061 99639 -422
- Misses 17395 17884 +489 |
MichaelScofield
approved these changes
Aug 30, 2023
sunng87
approved these changes
Aug 30, 2023
shuiyisong
force-pushed
the
feat/schema_opts
branch
from
8488581 to
b009a75
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: update proto * chore: add try from for schema name value * chore: merge schema opts to table opts while creating table * chore: use table ttl opts first * chore: add unit test * chore: update proto version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly adds
SchemaNameValuewhich containsttloption for schema(persisted at etcd)discussion: should we rename
SchemaNameValueto something else?wait for GreptimeTeam/greptime-proto#93 to be merge first
Checklist
Refer to a related PR or issue link (optional)