feat: consolidate Insert request related partitioning and distributed processing operations into Inserter by zhongzc · Pull Request #2346 · GreptimeTeam/greptimedb

zhongzc · 2023-09-08T06:28:33Z

I hereby agree to the terms of the GreptimeDB CLA

same for Delete requests

What's changed and what's your intention?

Remove frontend::instance::distributed::{inserter|deleter}
Add Partitioner for all {Insert|Delete} request converters to partition requests into region requests
Add handle_table_insert and handle_statement_insert to frontend::insert::Inserter
Add handle_table_insert to frontend::delete::Deleter
Remove handle in RegionServerHandler
frontend::insert::Inserter and frontend::delete::Deleter internally send distributed requests

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

codecov · 2023-09-08T06:40:52Z

Codecov Report

❗ No coverage uploaded for pull request base (migrate-region-server@1dd10f7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head afa0b15 differs from pull request most recent head bc5f6a3. Consider uploading reports for the commit bc5f6a3 to get more accurate results

Additional details and impacted files

@@                   Coverage Diff                    @@
##             migrate-region-server    #2346   +/-   ##
========================================================
  Coverage                         ?   77.54%           
========================================================
  Files                            ?      714           
  Lines                            ?   113737           
  Branches                         ?        0           
========================================================
  Hits                             ?    88192           
  Misses                           ?    25545           
  Partials                         ?        0

…ted mode Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

fengjiachun

LGTM

killme2008

Great job!

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

killme2008

LGTM

… processing operations into Inserter (#2346) * refactor: RegionRequest as param of RegionRequestHandler.handle Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: partition insert & delete reqs for both standalone and distributed mode Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: nit change Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * fix: wrong function nameg Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: do request in inserter & deleter Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: remove RegionRequestHandler.handle Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: rename table_creator Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: nit change Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: address comments Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: nit change Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> --------- Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

… processing operations into Inserter (GreptimeTeam#2346) * refactor: RegionRequest as param of RegionRequestHandler.handle Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: partition insert & delete reqs for both standalone and distributed mode Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: nit change Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * fix: wrong function nameg Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: do request in inserter & deleter Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: remove RegionRequestHandler.handle Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: rename table_creator Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: nit change Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: address comments Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: nit change Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> --------- Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

refactor: RegionRequest as param of RegionRequestHandler.handle

2923b4d

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

zhongzc requested review from fengjiachun and waynexia September 8, 2023 06:29

zhongzc marked this pull request as draft September 8, 2023 08:18

feat: partition insert & delete reqs for both standalone and distribu…

f0f9662

…ted mode Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

zhongzc changed the title ~~refactor: RegionRequest as param of RegionRequestHandler.handle~~ feat: partition insert & delete reqs for both standalone and distributed modes Sep 8, 2023

zhongzc marked this pull request as ready for review September 8, 2023 10:20

zhongzc added 4 commits September 8, 2023 10:28

chore: nit change

bfd9808

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

fix: wrong function nameg

70e4193

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

feat: do request in inserter & deleter

2480330

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

feat: remove RegionRequestHandler.handle

afa0b15

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

zhongzc changed the title ~~feat: partition insert & delete reqs for both standalone and distributed modes~~ feat: consolidate Insert request related partitioning and distributed processing operations into Inserter Sep 11, 2023

zhongzc added 2 commits September 11, 2023 06:32

refactor: rename table_creator

1d8fcae

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

chore: nit change

ec11d4a

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

fengjiachun approved these changes Sep 11, 2023

View reviewed changes

killme2008 reviewed Sep 11, 2023

View reviewed changes

zhongzc added 2 commits September 12, 2023 03:54

refactor: address comments

eb8a8e7

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

chore: nit change

bc5f6a3

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

killme2008 approved these changes Sep 12, 2023

View reviewed changes

killme2008 added this pull request to the merge queue Sep 12, 2023

Merged via the queue into GreptimeTeam:migrate-region-server with commit 6957fd1 Sep 12, 2023

zhongzc deleted the zhongzc/refactor-region-handler branch September 12, 2023 04:02

zhongzc restored the zhongzc/refactor-region-handler branch September 21, 2023 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: consolidate Insert request related partitioning and distributed processing operations into Inserter#2346

feat: consolidate Insert request related partitioning and distributed processing operations into Inserter#2346
killme2008 merged 10 commits intoGreptimeTeam:migrate-region-serverfrom
zhongzc:zhongzc/refactor-region-handler

zhongzc commented Sep 8, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Sep 8, 2023 •

edited

Loading

Uh oh!

fengjiachun left a comment

Uh oh!

killme2008 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

killme2008 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zhongzc commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's changed and what's your intention?

Checklist

Refer to a related PR or issue link (optional)

Uh oh!

codecov Bot commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fengjiachun left a comment

Choose a reason for hiding this comment

Uh oh!

killme2008 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

killme2008 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zhongzc commented Sep 8, 2023 •

edited

Loading

codecov Bot commented Sep 8, 2023 •

edited

Loading