feat: supports decimal type in RPC#2788
Merged
evenyag merged 12 commits intoGreptimeTeam:developfrom Nov 24, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2788 +/- ##
===========================================
- Coverage 84.47% 84.34% -0.14%
===========================================
Files 728 731 +3
Lines 113352 114517 +1165
===========================================
+ Hits 95756 96587 +831
- Misses 17596 17930 +334 |
evenyag
reviewed
Nov 22, 2023
evenyag
reviewed
Nov 22, 2023
Contributor
evenyag
left a comment
There was a problem hiding this comment.
I'll review the rest parts after the proto is updated.
evenyag
reviewed
Nov 24, 2023
killme2008
reviewed
Nov 24, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
evenyag
approved these changes
Nov 24, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
main change:
refactor ColumnDataTypeWrapper
ColumnDataTypeWrappercan convert withConcreteDataType.(refactorFrom/TryFromtrait).ColumnDataType::xxx_datatype()to create, as ConcreteDataType style.datatype()can get(ColumnDataType, Option<ColumnDataTypeExtension>), which is needed byColumnSchema,ColumnDefandColumn.try_newto construct aColumnDataTypeWrapper.Checklist
Refer to a related PR or issue link (optional)
#2682
GreptimeTeam/greptime-proto#122