feat(inverted_index.search): add fst applier#2851
Merged
waynexia merged 2 commits intoGreptimeTeam:developfrom Dec 4, 2023
Merged
feat(inverted_index.search): add fst applier#2851waynexia merged 2 commits intoGreptimeTeam:developfrom
waynexia merged 2 commits intoGreptimeTeam:developfrom
Conversation
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2851 +/- ##
===========================================
- Coverage 84.76% 84.44% -0.32%
===========================================
Files 737 740 +3
Lines 115748 116192 +444
===========================================
+ Hits 98112 98124 +12
- Misses 17636 18068 +432 |
evenyag
reviewed
Dec 1, 2023
evenyag
approved these changes
Dec 4, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
FstApplieris a broad term that denotes an abstraction that accepts anFstand returns values(Vec<u64>).The primary reason for proposing this abstraction is to allow for preprocessing of certain
Predicates, especially forInLists, so it is known from the outset which keys to retrieve. By using these keys to perform aFst::get(), the desired results can be obtained. Other predicates have a wider scope and require additional APIs from theFst, such asfst::range()andfst::search().The
FstApplierserves as a suitable abstraction to encompass the implementations of the various scenarios described above.Checklist
Refer to a related PR or issue link (optional)
#2705
The next PRs to be submitted:
feat(inverted_index.search): add fst values mapper
feat(inverted_index.search): add index applier