Skip to content

feat(inverted_index.search): add fst applier#2851

Merged
waynexia merged 2 commits intoGreptimeTeam:developfrom
zhongzc:zhongzc/index-fst-applier
Dec 4, 2023
Merged

feat(inverted_index.search): add fst applier#2851
waynexia merged 2 commits intoGreptimeTeam:developfrom
zhongzc:zhongzc/index-fst-applier

Conversation

@zhongzc
Copy link
Copy Markdown
Collaborator

@zhongzc zhongzc commented Nov 30, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

FstApplier is a broad term that denotes an abstraction that accepts an Fst and returns values(Vec<u64>).

The primary reason for proposing this abstraction is to allow for preprocessing of certain Predicates, especially for InLists, so it is known from the outset which keys to retrieve. By using these keys to perform a Fst::get(), the desired results can be obtained. Other predicates have a wider scope and require additional APIs from the Fst, such as fst::range() and fst::search().

The FstApplier serves as a suitable abstraction to encompass the implementations of the various scenarios described above.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

The next PRs to be submitted:
feat(inverted_index.search): add fst values mapper
feat(inverted_index.search): add index applier

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 30, 2023

Codecov Report

Merging #2851 (8fdd24f) into develop (fe2fc72) will decrease coverage by 0.32%.
Report is 1 commits behind head on develop.
The diff coverage is 95.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2851      +/-   ##
===========================================
- Coverage    84.76%   84.44%   -0.32%     
===========================================
  Files          737      740       +3     
  Lines       115748   116192     +444     
===========================================
+ Hits         98112    98124      +12     
- Misses       17636    18068     +432     

Comment thread Cargo.toml
Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cool Job!

@killme2008 killme2008 requested a review from evenyag December 1, 2023 13:33
Comment thread src/index/src/inverted_index/search/fst_apply/intersection_apply.rs
@waynexia waynexia enabled auto-merge December 4, 2023 08:04
@waynexia waynexia added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit 58c1373 Dec 4, 2023
@zhongzc zhongzc self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants