Skip to content

feat(inverted_index.search): add fst values mapper#2862

Merged
zhongzc merged 12 commits intoGreptimeTeam:developfrom
zhongzc:zhongzc/index-fst-values-mapper
Dec 4, 2023
Merged

feat(inverted_index.search): add fst values mapper#2862
zhongzc merged 12 commits intoGreptimeTeam:developfrom
zhongzc:zhongzc/index-fst-values-mapper

Conversation

@zhongzc
Copy link
Copy Markdown
Collaborator

@zhongzc zhongzc commented Dec 4, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add FstValuesMapper to map FST-encoded u64 values to their corresponding bitmaps

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

The next PRs to be submitted:
feat(inverted_index.search): add index applier

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2023

Codecov Report

Merging #2862 (65e47b7) into develop (58c1373) will decrease coverage by 0.42%.
Report is 3 commits behind head on develop.
The diff coverage is 92.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2862      +/-   ##
===========================================
- Coverage    84.77%   84.36%   -0.42%     
===========================================
  Files          743      745       +2     
  Lines       116811   116995     +184     
===========================================
- Hits         99026    98699     -327     
- Misses       17785    18296     +511     

Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/index/src/inverted_index/search/fst_values_mapper.rs Outdated
Comment thread src/index/src/inverted_index/search/fst_values_mapper.rs
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc enabled auto-merge December 4, 2023 13:20
@zhongzc zhongzc added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit a9db80a Dec 4, 2023
@zhongzc zhongzc self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants