feat(inverted_index.search): add index applier#2868
Merged
zhongzc merged 35 commits intoGreptimeTeam:developfrom Dec 5, 2023
Merged
feat(inverted_index.search): add index applier#2868zhongzc merged 35 commits intoGreptimeTeam:developfrom
zhongzc merged 35 commits intoGreptimeTeam:developfrom
Conversation
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
…' into zhongzc/index-applier
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
…' into zhongzc/index-applier
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
This was referenced Dec 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2868 +/- ##
===========================================
- Coverage 84.78% 84.33% -0.46%
===========================================
Files 745 749 +4
Lines 117025 117881 +856
===========================================
+ Hits 99223 99417 +194
- Misses 17802 18464 +662 |
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
…selectivity Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
evenyag
reviewed
Dec 5, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
zhongzc
force-pushed
the
zhongzc/index-applier
branch
from
74c2c67 to
91a1338
Compare
killme2008
reviewed
Dec 5, 2023
Member
killme2008
left a comment
killme2008
left a comment
There was a problem hiding this comment.
Good job! A few suggestions attached.
Another suggestion: maybe we can add some benchmarks for inverted index performance to get a baseline and prepare for future improvements.
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Collaborator
Author
Agreed. I will construct some bench cases with local files as the baseline in the upcoming PRs. |
evenyag
reviewed
Dec 5, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
evenyag
reviewed
Dec 5, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Introduce
IndexApplierto apply the predefined predicates to the data read by the given index reader, returning a list of relevant indices.Applier instances are reusable and work with various
InvertedIndexReaderinstances, avoiding repeated compilation of fixed predicates such as regex patterns.Checklist
Refer to a related PR or issue link (optional)
Prerequisite merging GreptimeTeam/greptime-proto#126
#2705