feat(mito): Add WriteCache struct and write SSTs to write cache#2999
Merged
Conversation
22 tasks
fdf5f7e to
168f05a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
==========================================
- Coverage 85.68% 85.13% -0.56%
==========================================
Files 806 806
Lines 131511 131563 +52
==========================================
- Hits 112689 112003 -686
- Misses 18822 19560 +738 |
killme2008
approved these changes
Jan 3, 2024
zhongzc
reviewed
Jan 3, 2024
zhongzc
reviewed
Jan 3, 2024
zhongzc
approved these changes
Jan 3, 2024
Contributor
Author
|
After some experiments, I plan to simplify the implementation of the write-through cache and upload files to object stores synchronously. Then we can remove |
Contributor
Author
zhongzc
approved these changes
Jan 4, 2024
killme2008
reviewed
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a skeleton for the
WriteCachethat serves as a write-through cache for object stores.WriteCache
The
WriteCachehas a local store to cache files.The
WriteCachehas awrite_and_upload_sst()method to write files to the cache (a local store) and upload them to object stores.Upload can be sync or async. We will implement the sync version first.
The
recover()method will recover the underlying file cache.The
AccessLayerhides the details of writing SSTs to the write cache.Checklist
Refer to a related PR or issue link (optional)