feat(mito): Init the write cache in datanode#3100
Merged
Merged
Conversation
12558fc to
c856ef9
Compare
22 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
- Coverage 85.66% 85.19% -0.48%
==========================================
Files 807 807
Lines 132167 132354 +187
==========================================
- Hits 113227 112755 -472
- Misses 18940 19599 +659 |
zhongzc
reviewed
Jan 5, 2024
zhongzc
reviewed
Jan 5, 2024
zhongzc
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR initializes the
WriteCacheaccording to the mito config. By default, the write cache is underDATA_HOME/write_cacheand is disabled.It addresses an issue that the file cache doesn't use
get()to access cache entries.It also refactors some mods to make the integration easier
CacheManagerFileCacheinWriteCache::newMitoEngine::newis an async function nowObjectStoreNow write cache is still an experimental feature so I added prefixes to its config items.
Checklist
Refer to a related PR or issue link (optional)