Skip to content

feat: write and upload sst#3106

Merged
evenyag merged 9 commits into
GreptimeTeam:mainfrom
QuenKar:feat/write-upload-sst
Jan 11, 2024
Merged

feat: write and upload sst#3106
evenyag merged 9 commits into
GreptimeTeam:mainfrom
QuenKar:feat/write-upload-sst

Conversation

@QuenKar
Copy link
Copy Markdown
Contributor

@QuenKar QuenKar commented Jan 5, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

part of #2965
write sst file to cache and upload it to remote object store

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2965

@github-actions github-actions Bot added docs-not-required This change does not impact docs. Size: M labels Jan 5, 2024
@QuenKar QuenKar force-pushed the feat/write-upload-sst branch from 3259d35 to bcc421e Compare January 8, 2024 02:11
@QuenKar QuenKar marked this pull request as ready for review January 8, 2024 02:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1fc168b) 85.52% compared to head (b695882) 85.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
- Coverage   85.52%   85.07%   -0.45%     
==========================================
  Files         818      818              
  Lines      133850   133971     +121     
==========================================
- Hits       114474   113975     -499     
- Misses      19376    19996     +620     

Comment thread src/mito2/src/cache/file_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/sst.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/file_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/file_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs
@QuenKar QuenKar force-pushed the feat/write-upload-sst branch from 6fb1f3c to 4587bf7 Compare January 9, 2024 06:30
@QuenKar QuenKar force-pushed the feat/write-upload-sst branch from 4587bf7 to fb454a8 Compare January 9, 2024 10:33
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs
Comment thread src/mito2/src/cache/write_cache.rs
QuenKar and others added 2 commits January 10, 2024 11:02
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Co-authored-by: Yingwen <realevenyag@gmail.com>
Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Jan 11, 2024
Merged via the queue into GreptimeTeam:main with commit 29a7f30 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants