feat: read data from write cache#3128
Conversation
4e5c168 to
a03037c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
- Coverage 85.48% 85.07% -0.42%
==========================================
Files 822 822
Lines 134403 134634 +231
==========================================
- Hits 114899 114540 -359
- Misses 19504 20094 +590 |
d04d84e to
61e9b74
Compare
|
After we merge this PR, could we remove the cache layer? |
Co-authored-by: Yingwen <realevenyag@gmail.com>
couldn't be removed yet, because we doesn't implement cache read file now, if data is not in WriteCache and we still rely on cache layer to cache read data. The Write Cache just caches the write file and upload to remote store. |
Got it. I believe our final goal is to merge these two components. |
evenyag
left a comment
There was a problem hiding this comment.
LGTM.
Could we add a case to test the engine with write cache enabled under mito2::engine mod? It could be done in the next PR.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
part of #2965
changes:
helper.rs.read_rangesfunction forFileCache.usizetou64Checklist
Refer to a related PR or issue link (optional)
#2965