Skip to content

test: engine with write cache#3163

Merged
evenyag merged 6 commits into
GreptimeTeam:mainfrom
QuenKar:test/engine-with-write-cache
Jan 15, 2024
Merged

test: engine with write cache#3163
evenyag merged 6 commits into
GreptimeTeam:mainfrom
QuenKar:test/engine-with-write-cache

Conversation

@QuenKar
Copy link
Copy Markdown
Contributor

@QuenKar QuenKar commented Jan 15, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

  • add write cache test for engine
  • remove unused for file cache and write cache
  • refactor my code style, use crate path instead of super

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions Bot added docs-not-required This change does not impact docs. Size: S and removed Size: S labels Jan 15, 2024
@QuenKar QuenKar marked this pull request as ready for review January 15, 2024 06:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1294d6f) 85.54% compared to head (75ef328) 84.96%.

❗ Current head 75ef328 differs from pull request most recent head 48b5c75. Consider uploading reports for the commit 48b5c75 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3163      +/-   ##
==========================================
- Coverage   85.54%   84.96%   -0.59%     
==========================================
  Files         829      827       -2     
  Lines      135711   135311     -400     
==========================================
- Hits       116096   114962    -1134     
- Misses      19615    20349     +734     

@QuenKar QuenKar requested a review from evenyag January 15, 2024 07:36
Comment thread src/mito2/src/cache/write_cache.rs Outdated
Comment thread src/mito2/src/cache/write_cache.rs Outdated
@QuenKar QuenKar force-pushed the test/engine-with-write-cache branch from 75ef328 to 48b5c75 Compare January 15, 2024 09:44
@QuenKar QuenKar requested a review from zhongzc January 15, 2024 10:00
Copy link
Copy Markdown
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Jan 15, 2024
Merged via the queue into GreptimeTeam:main with commit 07de65d Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants